feat: support different USE statement syntaxes#1387
Merged
Conversation
git-hulk
reviewed
Aug 19, 2024
8 tasks
iffyio
reviewed
Aug 20, 2024
e7690a7 to
984d805
Compare
iffyio
approved these changes
Aug 22, 2024
alamb
approved these changes
Aug 23, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @kacpermuda and @iffyio
This change makes sense to me
Pull Request Test Coverage Report for Build 10509933459Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Contributor
|
🚀 |
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to add support for different syntaxes of the
USEstatement, used to set a default DATABASE/SCHEMA for set of queries.Some implementations are calling their top level structure
CATALOG(e.g. Databricks, Trino), but most of them stick toDATABASEso I assumed that we should stick to naming:top-level container = DATABASE,lower-level container = SCHEMA. For the full identifier we end up with:DATABASE.SCHEMA.TABLE.In some implementations
DATABASEandSCHEMAare aliases, but usually these implementations have a two-layer structure (DATABASE.TABLE, withoutSCHEMA) - in that case we should keepDATABASEasDATABASEand leaveSCHEMAempty.There are different syntaxes of USE statement across dialects, but I implemented it like:
(use syntax => resolved db and schema names)
USE x;->DATABASE=x; SCHEMA=null;(Databricks is adjusted toDATABASE=null; SCHEMA=x;)USE x.y;->DATABASE=x; SCHEMA=y;USE DATABASE x;->DATABASE=x; SCHEMA=null;(Databricks is adjusted toDATABASE=null; SCHEMA=x;In DatabricksDATABASEis an alias forSCHEMAand they both mean lower level structure while the top level structure is calledCATALOG)USE SCHEMA y;->DATABASE=null; SCHEMA=y;USE SCHEMA x.y;->DATABASE=x; SCHEMA=y;(Snowflake specific syntax, SCHEMA keyword is optional and should not influence the parsing of fully qualified name)USE CATALOG x;->DATABASE=x; SCHEMA=null;(Databricks-specific keyword:CATALOG)USE DEFAULT;->DATABASE=null; SCHEMA=null;(Hive specific, means going back to default database set - we don't know what it is just by looking at the query.)Docs about USE statement in different dialects:
Some comments: