-
Notifications
You must be signed in to change notification settings - Fork 669
Add support of table function WITH ORDINALITY modifier for Postgre Parser #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of table function WITH ORDINALITY modifier for Postgre Parser #1337
Conversation
|
@lovasoa Can help to review when you get time, thank you! |
Pull Request Test Coverage Report for Build 9858237496Details
💛 - Coveralls |
lovasoa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WITH ORDINALITY is also supported after UNNEST, which I think needs special handling in sqlparser
Yes, good catch. Done in commit: a3cb42a. |
a3cb42a to
b8a08a7
Compare
lovasoa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me!
👍
|
cc @alamb |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This closes #1336