Skip to content

Support TO in CREATE VIEW clause for Clickhouse #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 23, 2024
Merged

Support TO in CREATE VIEW clause for Clickhouse #1313

merged 18 commits into from
Jun 23, 2024

Conversation

Bidaya0
Copy link
Contributor

@Bidaya0 Bidaya0 commented Jun 15, 2024 •
edited
Loading

iffyio
iffyio reviewed Jun 15, 2024
View reviewed changes
Bidaya0 and others added 5 commits June 16, 2024 23:41
@Bidaya0 @iffyio
Update src/ast/mod.rs
470982f 
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
@Bidaya0 @iffyio
Update tests/sqlparser_clickhouse.rs
4bcbbe0 
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
@Bidaya0 @iffyio
Update src/parser/mod.rs
3191129 
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
@Bidaya0 @iffyio
Update tests/sqlparser_clickhouse.rs
f9f5765 
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
@Bidaya0
cargo fmt and split sql into multiline.
5825517
@Bidaya0
Copy link
Contributor Author

Bidaya0 commented Jun 16, 2024

@iffyio
Thanks , I have made the changes as you suggested.

@Bidaya0 Bidaya0 requested a review from iffyio June 17, 2024 07:14
iffyio
iffyio reviewed Jun 19, 2024
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a minor comment regarding docs, otherwise LGTM! cc @alamb

@alamb alamb changed the title Feature/add materialized view to Support TO in CREATE VIEW clause for Cickhouse Jun 23, 2024
@alamb alamb changed the title Support TO in CREATE VIEW clause for Cickhouse Support TO in CREATE VIEW clause for Clickhouse Jun 23, 2024
alamb
alamb approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Bidaya0 and @iffyio for the erview

@alamb
Copy link
Contributor

alamb commented Jun 23, 2024

I pushed a change to this PR to resolve cargo fmt

@coveralls
Copy link

coveralls commented Jun 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9600072287

Details

  • 26 of 29 (89.66%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 88.994%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 81.49%
Totals Coverage Status
Change from base Build 9620505751: 0.003%
Covered Lines: 26215
Relevant Lines: 29457
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9632957350

Details

  • 26 of 29 (89.66%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 88.994%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 81.49%
Totals Coverage Status
Change from base Build 9620505751: 0.003%
Covered Lines: 26215
Relevant Lines: 29457
💛 - Coveralls

@alamb alamb merged commit f3d2f78 into apache:main Jun 23, 2024
10 checks passed
@Jesse-Bakker Jesse-Bakker mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio left review comments

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bidaya0 @alamb @coveralls @iffyio