Skip to content

ClickHouse: create view with fields and data types #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2024

Conversation

7phs
Copy link
Contributor

@7phs 7phs commented May 28, 2024

The CREATE VIEW syntax for ClickHouse is a bit different from many warehouses in the sense that you can specify the type of the columns when creating the view instead of them being deferred.

This PR extends parsing CREATE VIEW with this way of declaring view in ClickHouse.

Related issue: #1277

@7phs 7phs changed the title [1285] ClickHouse: create view with fields and data types ClickHouse: create view with fields and data types May 28, 2024
@coveralls
Copy link

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 9267897390

Details

  • 35 of 35 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 89.489%

Totals Coverage Status
Change from base Build 9212358328: 0.01%
Covered Lines: 24954
Relevant Lines: 27885

💛 - Coveralls

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @7phs and @iffyio for the review 🙏

@alamb alamb merged commit 375742d into apache:main May 30, 2024
10 checks passed
@7phs 7phs deleted the click-house-create-view branch May 30, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants