Skip to content

Remove "SQL" prefix from "SQLDateTimeField" struct #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Jun 25, 2019

I realized a moment too late that I'd missed a type name in
when removing the "SQL" prefix from types in ac555d7. As far as I can
tell, this was the only oversight.

I realized a moment too late that I'd missed a type name in
when removing the "SQL" prefix from types in ac555d7. As far as I can
tell, this was the only oversight.
@benesch benesch requested a review from nickolay June 25, 2019 17:25
@coveralls
Copy link

coveralls commented Jun 25, 2019

Pull Request Test Coverage Report for Build 380

  • 27 of 27 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.239%

Totals Coverage Status
Change from base Build 378: 0.0%
Covered Lines: 4326
Relevant Lines: 4690

💛 - Coveralls

Copy link
Contributor

@nickolay nickolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Not sure there’s a point in reviewing changes like this before merging.)

@benesch
Copy link
Contributor Author

benesch commented Jun 25, 2019

(Not sure there’s a point in reviewing changes like this before merging.)

Sure, happy to just merge tiny stuff like this without waiting for approval!

@benesch benesch merged commit f7199ec into apache:master Jun 25, 2019
@benesch benesch deleted the sqlprefix-missed branch June 25, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants