-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add identifier quote style to Dialect
trait
#1170
Conversation
cc @alamb |
Looks good to me -- thank you @backkem I think before we could merge this PR we need some tests ( mostly so if it got broken by accident in the future we would know because a test would fail) |
Pull Request Test Coverage Report for Build 8238316231Details
💛 - Coveralls |
I added a basic test. It feels somewhat artificial but I didn't want to build additional 'unparser' logic in the test case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a basic test. It feels somewhat artificial but I didn't want to build additional 'unparser' logic in the test case.
I agree it feels somewhat forced, but I think that is also OK in this case. We can improve things later if necessary.
Thank you @backkem
Dialect
trait
(cherry picked from commit 929c646)
This relates to apache/datafusion#9517 where we're adding an SQL
unparser
to turn DataFusion Expr/Plans back into SQL.I extended the method to allow passing the identifier value. This may be helpful in case we want to add heuristics to only add quotes if truly needed by the dialect.