Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crates release? #204

Closed
maxcountryman opened this issue Jun 20, 2020 · 17 comments
Closed

New Crates release? #204

maxcountryman opened this issue Jun 20, 2020 · 17 comments
Assignees

Comments

@maxcountryman
Copy link
Contributor

I'm wondering if it's possible to author a new Crates release containing the recent changes? It seems that without a published crate, I'm unable to bring these changes into my own crates.

@nickolay
Copy link
Contributor

You'll have to get hold of @andygrove for that, as he's the only one who can do a release.

@Dandandan
Copy link
Contributor

Would it an idea to keep the crates.io secrets in GitHub so we can setup an automated way of releasing via a workflow (with git tags for example).

@Dandandan
Copy link
Contributor

Like this: https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets#using-encrypted-secrets-in-a-workflow

And yes, I would also would love a new release for the recent create table as addition :).

@andygrove
Copy link
Member

This sounds good. I'm also open to giving others permissions to publish.

@andygrove
Copy link
Member

I can take care of a release this evening to at least unblock people for now.

@andygrove andygrove self-assigned this Jun 25, 2020
@andygrove
Copy link
Member

0.5.1 is published. In hindsight I should probably have released as 0.6.0. Hopefully there aren't any major breaking changes.

@Dandandan
Copy link
Contributor

Super, thanks!

@nickolay
Copy link
Contributor

@andygrove Thanks! I've updated the changelog to note that: andygrove@0c82be5

@maxcountryman
Copy link
Contributor Author

Thanks, Andy!

@Dandandan
Copy link
Contributor

Would it maybe be an idea to either give someone else permission to publish? I think @nickolay is the most active in here . We could also setup this for publishing a crate:

https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets#using-encrypted-secrets-in-a-workflow

This could work the same way like @maxcountryman has implemented for forma:

https://github.com/maxcountryman/forma/blob/master/.github/workflows/main.yml#L88

@andygrove
Copy link
Member

andygrove commented Jun 26, 2020 via email

@nickolay
Copy link
Contributor

Thanks, I've registered https://crates.io/users/nickolay , but if anyone else is willing to take care of the release process, I'd be happy to stand back.

In particular, if @Dandandan or @maxcountryman volunteered (wink), I would be in favor of giving them the necessary permissions. They have been active on the project recently, and it would be an honor to have them on the team officially!

@Dandandan
Copy link
Contributor

I would like to help with this!

If you also add me to the GitHub repo I can also implement the tag-based release process like I linked to.

My github / crates handle is Dandandan.

@andygrove
Copy link
Member

ok @Dandandan aND @nickolay you should both have invites got crates.io and @Dandandan also has an invite to collaborate on this repo.

I just moved the repo under the ballista-compute org as well.

@maxcountryman
Copy link
Contributor Author

It sounds like there's enough people to take care of the processes, but if it's helpful I'm also happy to volunteer. 🙂

@andygrove
Copy link
Member

@maxcountryman Invites sent!

@maxcountryman
Copy link
Contributor Author

Thanks, Andy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants