feat: add python bindings for ends_with function#693
Conversation
richtia
force-pushed
the
ends_with_function
branch
from
1dff1fa to
4d37a39
Compare
|
Looks like I accidentally deleted a line i changed on my rebase. added back the wrap pyfunction. |
src/functions.rs
Outdated
| ); | ||
| expr_fn!(sqrt, num); | ||
| expr_fn!(starts_with, arg1 arg2, "Returns true if string starts with prefix."); | ||
| expr_fn!(ends_with, arg1 arg2, "Returns true if string ends with suffix."); |
There was a problem hiding this comment.
We should probably match the argument names to upstream: string suffix
(I assume you just matched what starts_with has. That was either my error as I made the initial port or the upstream UDF changed)
https://docs.rs/datafusion/latest/datafusion/functions/expr_fn/fn.ends_with.html
There was a problem hiding this comment.
updated! Also updated the argument names for starts_with
There was a problem hiding this comment.
actually...looks like the upstream for starts_with is arg1, and arg2...should i revert it back?
https://docs.rs/datafusion/latest/datafusion/functions/expr_fn/fn.starts_with.html
There was a problem hiding this comment.
:D yea - UDF's are going through rapid iteration in upstream datafusion, so the conventions are still being ironed out.
Michael-J-Ward
left a comment
Michael-J-Ward
left a comment
There was a problem hiding this comment.
I'm fine with clarifying argument names for starts_with. I assume upstream will get switched to this eventually.
richtia
force-pushed
the
ends_with_function
branch
from
32983ec to
ada9d18
Compare
Just rebased |
3 participants
Which issue does this PR close?
ends_with function is missing from datafusion_python