Prepare for 22.0.0 release #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently blocked on apache/datafusion#5949 |
andygrove
commented
Apr 10, 2023
datafusion/tests/test_context.py
Outdated
| @@ -282,10 +282,11 @@ def test_dataset_filter_nested_data(ctx): | |||
|
|
|||
| # This filter will not be pushed down to DatasetExec since it | |||
| # isn't supported | |||
| df = df.select( | |||
| df = df.filter(column("nested_data")["b"] > literal(5))\ | |||
There was a problem hiding this comment.
Move the filter before the select due to apache/datafusion#5949
andygrove
commented
Apr 10, 2023
datafusion/tests/test_dataframe.py
Outdated
| @@ -84,10 +84,11 @@ def test_select_columns(df): | |||
|
|
|||
|
|
|||
| def test_filter(df): | |||
| df = df.select( | |||
| df = df.filter(column("a") > literal(2))\ | |||
There was a problem hiding this comment.
Move the filter before the select due to apache/datafusion#5949
|
@jdye64 fyi |
|
Thanks for the heads up @andygrove anything you need me to help with? I'll keep an eye on any CI test failures. Still all running as of writing |
No, all good. Just wanted to make you aware this was happening. I will cut an RC today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?