chore: fix publish-to-maven script #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parthchandra fyi |
andygrove
commented
Sep 25, 2024
| @@ -80,7 +80,7 @@ then | |||
| fi | |||
|
|
|||
| # Default GPG command to use | |||
| GPG="gpg" | |||
| GPG="gpg --pinentry-mode loopback" | |||
There was a problem hiding this comment.
I got gpg timeouts before I added this
There was a problem hiding this comment.
Thanks for fixing this @andygrove, I should have done this in the first place.
andygrove
commented
Sep 25, 2024
| @@ -96,7 +96,7 @@ GIT_HASH=$(git rev-parse --short HEAD) | |||
| echo "Creating Nexus staging repository" | |||
|
|
|||
| REPO_REQUEST="<promoteRequest><data><description>Apache Datafusion Comet $COMET_VERSION (commit $GIT_HASH)</description></data></promoteRequest>" | |||
| REPO_REQUEST_RESPONSE=$(curl -I -X POST -d "$REPO_REQUEST" -u $ASF_USERNAME:$ASF_PASSWORD \ | |||
| REPO_REQUEST_RESPONSE=$(curl -X POST -d "$REPO_REQUEST" -u $ASF_USERNAME:$ASF_PASSWORD \ | |||
There was a problem hiding this comment.
I got an error about using multiple http methods before changing this
parthchandra
approved these changes
Sep 25, 2024
| @@ -80,7 +80,7 @@ then | |||
| fi | |||
|
|
|||
| # Default GPG command to use | |||
| GPG="gpg" | |||
| GPG="gpg --pinentry-mode loopback" | |||
There was a problem hiding this comment.
Thanks for fixing this @andygrove, I should have done this in the first place.
viirya
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Fix two issues that I ran into when publishing 0.3.0-rc1.
What changes are included in this PR?
How are these changes tested?