Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable Comet shuffle for Spark core-1 test #924

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Conversation

viirya
Copy link
Member

@viirya viirya commented Sep 8, 2024

Which issue does this PR close?

Closes #930.

Rationale for this change

We disabled Comet shuffle for Spark core-1 test because negative ref count issue reported by Java Arrow. After fixing memory issues and some changes to more follow C Data interface, we may re-enable Comet shuffle for Spark core-1 test in CI.

What changes are included in this PR?

How are these changes tested?

@viirya viirya marked this pull request as draft September 8, 2024 21:52
@viirya viirya changed the title test chore: Enable Comet shuffle for Spark core-1 test Sep 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.15%. Comparing base (033fe6f) to head (9fb03f1).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #924      +/-   ##
============================================
+ Coverage     34.03%   34.15%   +0.11%     
+ Complexity      883      882       -1     
============================================
  Files           113      112       -1     
  Lines         43170    43237      +67     
  Branches       9516     9562      +46     
============================================
+ Hits          14693    14766      +73     
+ Misses        25471    25455      -16     
- Partials       3006     3016      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viirya
Copy link
Member Author

viirya commented Sep 9, 2024

Seems negative ref count issue was fixed by previous commits revising array import/export.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @viirya
1 minor why we have RUST_BACKTRACE enabled for ansi workflow test and disabled for regular one?

@viirya
Copy link
Member Author

viirya commented Sep 9, 2024

lgtm thanks @viirya 1 minor why we have RUST_BACKTRACE enabled for ansi workflow test and disabled for regular one?

Thanks @comphead

I'm not sure about it. Maybe we have added it for debugging ansi workflow before?

@viirya viirya merged commit 8c15cf4 into apache:main Sep 9, 2024
75 checks passed
@viirya viirya deleted the test branch September 9, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Comet shuffle for Spark core-1 test
3 participants