chore: disable ORC in Iceberg Spark tests#4999
Open
hsiang-c wants to merge 5 commits into
Open
Conversation
hsiang-c
force-pushed
the
disable_orc_in_iceberg_spark
branch
from
July 22, 2026 00:57
b769a9d to
af3ea84
Compare
hsiang-c
force-pushed
the
disable_orc_in_iceberg_spark
branch
from
July 22, 2026 01:07
af3ea84 to
8791826
Compare
hsiang-c
marked this pull request as ready for review
July 22, 2026 05:55
Contributor
|
One thing we might want to add is a test to CometIcebergNativeSuite that uses ORC as the data file type, that way we at least have a self-contained test that the fallback is working correctly. |
Contributor
|
Interestingly, this doesn't seem to save much time in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4586
Rationale for this change
What changes are included in this PR?
parameters()providersObject[]/Object[][]entries that passFileFormat.ORCor"orc"SparkRowLevelOperationsTestBase,TestRowLevelOperationsWithLineage,TestFilteredScan,TestPartitionPruning,TestPartitionValues,TestSparkReadProjection,TestSparkMetadataColumns,TestSparkReaderDeletes,TestSparkScan,TestSparkDataWrite,TestIdentityPartitionData,TestMetadataTablesWithPartitionEvolution,TestPositionDeletesTable,TestDataFrameWriterV2Coercion,TestCompressionSettingsimport org.junit.jupiter.api.Disabled;and annotate the class with@DisabledTestOrcWrite,TestSparkOrcReader,TestSparkOrcReadMetadataColumns,TestSparkRecordOrcReaderWriter,TestVectorizedOrcDataReader,TestORCDataFrameWrite@TestTemplate/@Testwith@Disabledon the single ORC caseTestRewriteTablePathsAction#testPositionDeletesOrc()TestSparkCompressionUtil(deletetestOrcCompressionRatios()+ ORC branches, removeimport static …FileFormat.ORC);TestSparkWriteConf(delete ORC compression cases +ORC_COMPRESSION,ORC_COMPRESSION_STRATEGY,DELETE_ORC_COMPRESSION,DELETE_ORC_COMPRESSION_STRATEGYimports);TestCompressionSettings(dropORC_COMPRESSION/DELETE_ORC_COMPRESSIONput()calls + imports);TestStructuredStreamingRead3(removeorcFileRecords, itsappendData(…, "orc"), and the ORC part of the expected-result assertion)How are these changes tested?
Running Iceberg Spark 4.1 with the new
1.11.0.diff