chore: Implement remaining CAST tests #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
May 1, 2024
Comment on lines
-91
to
92
|
|
||
| ignore("cast BooleanType to ByteType") { | ||
| // https://github.com/apache/datafusion-comet/issues/311 | ||
| test("cast BooleanType to ByteType") { | ||
| castTest(generateBools(), DataTypes.ByteType) | ||
| } |
There was a problem hiding this comment.
This is not supported before and supported now?
There was a problem hiding this comment.
Not quite. It was disabled before and now it is enabled. With this PR, I enabled all of the tests and then kept the ones that are passing.
viirya
approved these changes
May 1, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
During the docker build, additional repos are added which still use mirrorlist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #286
Rationale for this change
Implement more tests.
Status:
What changes are included in this PR?
ignoretotestHow are these changes tested?