Skip to content

Conversation

@coderfender
Copy link
Contributor

@coderfender coderfender commented Feb 3, 2026

Which issue does this PR close?

Adds cast support from date to timestamp

Closes #.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.02%. Comparing base (f09f8af) to head (4c6eb3a).
⚠️ Report is 923 commits behind head on main.

Files with missing lines Patch % Lines
...scala/org/apache/comet/expressions/CometCast.scala 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3383      +/-   ##
============================================
+ Coverage     56.12%   60.02%   +3.89%     
- Complexity      976     1475     +499     
============================================
  Files           119      175      +56     
  Lines         11743    16184    +4441     
  Branches       2251     2688     +437     
============================================
+ Hits           6591     9714    +3123     
- Misses         4012     5114    +1102     
- Partials       1140     1356     +216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderfender
Copy link
Contributor Author

@parthchandra , @andygrove . Please take a look whenever you get a chance .

@coderfender
Copy link
Contributor Author

I believe I can piggy back Date -> numeric types (which always return null) in thr PR or perhaps in a different PR if you think that is a good idea ? (Date -> Int is more a formality than adding additional logic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants