docs: fix inaccurate claim about mutable buffers in parquet scan docs #3378
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentation The documentation incorrectly claimed that native_iceberg_compat "removes the use of reusable mutable-buffers". In reality, both native_comet and native_iceberg_compat use reusable mutable buffers when transferring data via Arrow FFI. This commit: - Removes the inaccurate claim - Replaces it with accurate description of Parquet decoding delegation - Adds a note explaining the actual mutable buffer behavior - Links to the FFI documentation for details on arrow_ffi_safe flag Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
comphead
reviewed
Feb 3, 2026
| - Delegates Parquet decoding to native Rust code rather than JVM-side decoding | ||
| - Improves performance | ||
|
|
||
| > **Note on mutable buffers:** Both `native_comet` and `native_iceberg_compat` use reusable mutable buffers |
Contributor
There was a problem hiding this comment.
wondering should we note changes in #3367 it is not a native reusable buffer, but stating the JVM unsafe rows are copied?
Member
Author
There was a problem hiding this comment.
This document is specifically about the Parquet scan implementations, so seems unrelated
Member
Author
|
It looks I am still misunderstanding some of this, so moving to draft while I clarify some things. |
Clarified note on mutable buffers and updated details on `native_iceberg_compat` implementation.
Member
Author
Ok, I think this is accurate now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The documentation incorrectly claimed that
native_iceberg_compat"removes the use of reusable mutable-buffers". I had misunderstood this, apparently.What changes are included in this PR?
How are these changes tested?