fix: add scalar support for bit_count expression #3361
+55
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bit_count function now handles scalar inputs in addition to arrays. Scalar inputs return scalar outputs, maintaining proper type semantics. Enable bit_count tests in bitwise.sql Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3361 +/- ##
============================================
+ Coverage 56.12% 59.95% +3.82%
- Complexity 976 1475 +499
============================================
Files 119 175 +56
Lines 11743 16165 +4422
Branches 2251 2681 +430
============================================
+ Hits 6591 9692 +3101
- Misses 4012 5122 +1110
- Partials 1140 1351 +211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bit_count function now handles scalar inputs in addition to arrays. Scalar inputs return scalar outputs, maintaining proper type semantics.
Enable bit_count tests in bitwise.sql
Which issue does this PR close?
Closes #3341
Rationale for this change
Current implementation doesn't take scalar input.
What changes are included in this PR?
Boolean,Byte,Short,IntegerandLonglike Spark does.How are these changes tested?
CometBitwiseExpressionSuite.scalaby disablingConstantFolding.