Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add CI for TPC-H queries #220

Merged
merged 2 commits into from
Mar 22, 2024
Merged

build: Add CI for TPC-H queries #220

merged 2 commits into from
Mar 22, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 20, 2024

Which issue does this PR close?

Closes #219.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.32%. Comparing base (eb6c704) to head (5cbfea7).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #220   +/-   ##
=========================================
  Coverage     33.32%   33.32%           
  Complexity      768      768           
=========================================
  Files           107      107           
  Lines         37037    37037           
  Branches       8106     8106           
=========================================
  Hits          12341    12341           
  Misses        22099    22099           
  Partials       2597     2597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viirya
Copy link
Member Author

viirya commented Mar 21, 2024

This is blocked by #218.

@viirya
Copy link
Member Author

viirya commented Mar 21, 2024

@sunchao

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nit: maybe we can merge tpch and tpc-ds into one workflow file since we share the same time consuming part: generate the native lib in release mode. But that should be addressed in another PR or this is good enough.

@viirya viirya merged commit 4329838 into apache:main Mar 22, 2024
28 checks passed
@viirya
Copy link
Member Author

viirya commented Mar 22, 2024

Merged. Thanks.

@viirya viirya deleted the add_tpch_ci branch March 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI for TPC-H queries
4 participants