-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add CI for TPC-H queries #220
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
=========================================
Coverage 33.32% 33.32%
Complexity 768 768
=========================================
Files 107 107
Lines 37037 37037
Branches 8106 8106
=========================================
Hits 12341 12341
Misses 22099 22099
Partials 2597 2597 ☔ View full report in Codecov by Sentry. |
This is blocked by #218. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Nit: maybe we can merge tpch and tpc-ds into one workflow file since we share the same time consuming part: generate the native lib in release mode. But that should be addressed in another PR or this is good enough.
Merged. Thanks. |
Which issue does this PR close?
Closes #219.
Rationale for this change
What changes are included in this PR?
How are these changes tested?