test: Follow up on Spark 3.4 diff #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
============================================
- Coverage 33.54% 33.54% -0.01%
- Complexity 769 770 +1
============================================
Files 107 107
Lines 35470 35517 +47
Branches 7723 7751 +28
============================================
+ Hits 11899 11913 +14
- Misses 21079 21100 +21
- Partials 2492 2504 +12 ☔ View full report in Codecov by Sentry. |
|
cc @viirya |
viirya
reviewed
Mar 16, 2024
| new file mode 100644 | ||
| index 00000000000..4b31bea33de | ||
| --- /dev/null | ||
| +++ b/sql/core/src/test/scala/org/apache/spark/sql/IgnoreComet.scala |
There was a problem hiding this comment.
This is main change? DisableCometSuite -> IgnoreCometSuite?
sunchao
commented
Mar 16, 2024
| + op.asInstanceOf[CometExec].originalPlan.find(_.isInstanceOf[SortExec]).isDefined) | ||
| + }.isDefined == sortLeft, | ||
| + | ||
| + joinOperator.left.exists(op => op.isInstanceOf[ShuffleExchangeExec] || |
There was a problem hiding this comment.
For op.isInstanceOf[ShuffleExchangeExec], don't we need to check if it equals to shuffleLeft?
There was a problem hiding this comment.
hmm? it is checked in the code:
exists(op => op.isInstanceOf[ShuffleExchangeExec] || op.isInstanceOf[CometShuffleExchangeExec]) == shuffleLeft
viirya
reviewed
Mar 16, 2024
Comment on lines
-985
to
-988
| + op.isInstanceOf[SortExec] || | ||
| + (op.isInstanceOf[CometExec] && | ||
| + op.asInstanceOf[CometExec].originalPlan.find(_.isInstanceOf[SortExec]).isDefined) | ||
| + }.isDefined == sortLeft, |
There was a problem hiding this comment.
I forgot why we changed to check sort instead of shuffle here.
viirya
approved these changes
Mar 16, 2024
advancedxy
approved these changes
Mar 18, 2024
|
Thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Certain changes to address comments from #166 were somehow excluded in the final commit. This adds them back.
What changes are included in this PR?
How are these changes tested?