Skip to content

chore: Drop support for Java 8 #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 3 commits into from
May 23, 2025
Merged

chore: Drop support for Java 8 #1777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f835e57
drop support for Java 8
andygrove May 22, 2025
fe8b49b
Merge remote-tracking branch 'apache/main' into drop-java-8
andygrove May 23, 2025
a813e93
Update development.md
andygrove May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/pr_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
java_version: [8, 11, 17]
java_version: [11, 17]
test-target: [rust, java]
spark-version: ['3.5']
scala-version: ['2.12', '2.13']
Expand Down Expand Up @@ -180,7 +180,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
java_version: [8, 11, 17]
java_version: [11, 17]
test-target: [java]
spark-version: ['3.4']
scala-version: ['2.12', '2.13']
Expand All @@ -205,7 +205,7 @@ jobs:
strategy:
matrix:
os: [macos-13]
java_version: [8, 11, 17]
java_version: [11, 17]
test-target: [rust, java]
spark-version: ['3.4', '3.5']
scala-version: ['2.12', '2.13']
Expand All @@ -232,7 +232,7 @@ jobs:
macos-aarch64-test:
strategy:
matrix:
java_version: [8, 11, 17]
java_version: [11, 17]
test-target: [rust, java]
spark-version: ['3.4', '3.5']
scala-version: ['2.12', '2.13']
Expand Down Expand Up @@ -318,7 +318,7 @@ jobs:
macos-aarch64-test-with-old-spark:
strategy:
matrix:
java_version: [8, 17]
java_version: [17]
test-target: [java]
spark-version: ['3.4']
scala-version: ['2.12', '2.13']
Expand Down
2 changes: 1 addition & 1 deletion docs/source/contributor-guide/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ under the License.

## Development Setup

1. Make sure `JAVA_HOME` is set and point to JDK 8/11/17 installation.
1. Make sure `JAVA_HOME` is set and point to JDK using (support matrix)[docs/source/user-guide/installation.md]
2. Install Rust toolchain. The easiest way is to use
[rustup](https://rustup.rs).

Expand Down
12 changes: 6 additions & 6 deletions docs/source/user-guide/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ We recommend only using Comet with Spark versions where we currently have both C
Other versions may work well enough for development and evaluation purposes.

| Spark Version | Java Version | Scala Version | Comet Tests in CI | Spark Tests in CI |
| ------------- | ------------ | ------------- |-------------------| ----------------- |
| 3.4.3 | 8/11/17 | 2.12/2.13 | Yes | Yes |
| 3.5.2 | 8/11/17 | 2.12/2.13 | Partial\* | No |
| 3.5.3 | 8/11/17 | 2.12/2.13 | Partial\* | No |
| 3.5.4 | 8/11/17 | 2.12/2.13 | Partial\* | Yes |
| 3.5.5 | 8/11/17 | 2.12/2.13 | Yes | Yes |
| ------------- | ------------ | ------------- | ----------------- | ----------------- |
| 3.4.3 | 11/17 | 2.12/2.13 | Yes | Yes |
| 3.5.2 | 11/17 | 2.12/2.13 | Partial\* | No |
| 3.5.3 | 11/17 | 2.12/2.13 | Partial\* | No |
| 3.5.4 | 11/17 | 2.12/2.13 | Partial\* | Yes |
| 3.5.5 | 11/17 | 2.12/2.13 | Yes | Yes |

\* For older Spark 3.5.x releases, we do not test the full matrix of supported Java and Scala versions in CI.

Expand Down
13 changes: 0 additions & 13 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,19 +627,6 @@ under the License.
</properties>
</profile>

<profile>
<id>jdk1.8</id>
<activation>
<jdk>1.8</jdk>
</activation>
<properties>
<java.version>1.8</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<spotless.version>2.29.0</spotless.version>
</properties>
</profile>

<profile>
<id>jdk11</id>
<activation>
Expand Down
Loading