chore: Drop support for Spark 3.3 (EOL) #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
============================================
+ Coverage 56.12% 58.64% +2.51%
- Complexity 976 1014 +38
============================================
Files 119 123 +4
Lines 11743 12247 +504
Branches 2251 2290 +39
============================================
+ Hits 6591 7182 +591
+ Misses 4012 3919 -93
- Partials 1140 1146 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kazuyukitanimura
approved these changes
Mar 14, 2025
| case _ => false | ||
| } | ||
|
|
||
| protected def evalMode(c: Cast): CometEvalMode.Value = |
Contributor
There was a problem hiding this comment.
(Optional) now evalMode can be a common method
| | from tbl1 t1 join tbl2 t2 on t1._id = t2._id | ||
| | order by t1._id""".stripMargin) | ||
| } | ||
| // decimal support requires Spark 3.4 or later |
Contributor
There was a problem hiding this comment.
nit we can remove this comment
| /** | ||
| * This test suite contains tests for only Spark 3.4+. | ||
| */ | ||
| class CometExec3_4PlusSuite extends CometTestBase { |
Contributor
There was a problem hiding this comment.
(optional) since Spark 3.4 is the lowest version, we may be able to move this into the regular test location
Contributor
|
cc @huaxingao you may be able to remove the some of the duplicated code for Iceberg after this PR |
Member
Author
|
Thanks for the review @kazuyukitanimura |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #646
Rationale for this change
Spark 3.3 is EOL. Let's drop support now and reduce the CI overhead.
What changes are included in this PR?
How are these changes tested?