chore: See which Spark SQL tests fail if we set default shuffle mode to jvm #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We currently fall back to Spark for shuffle in some cases if shuffle mode is
autoornativeand a shuffle is not supported, rather than trying to fall back to Comet columner shuffle. Fixing this limitation in #1209 caused a number of Spark SQL tests to start failing because we are now running more queries in Comet.The goal of this PR is simply to demonstrate that changing our default shuffle mode will cause some Spark SQL tests to fail.
What changes are included in this PR?
How are these changes tested?