Skip to content

fix: [comet-parquet-exec] Add CometNativeScanExec support to checkParquetScan #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: [comet-parquet-exec] Add CometNativeScanExec support to checkParquetScan #1160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ import org.apache.spark.SparkException
import org.apache.spark.sql.{CometTestBase, DataFrame, Row}
import org.apache.spark.sql.catalyst.expressions.GenericInternalRow
import org.apache.spark.sql.catalyst.util.DateTimeUtils
import org.apache.spark.sql.comet.CometBatchScanExec
import org.apache.spark.sql.comet.CometScanExec
import org.apache.spark.sql.comet.{CometBatchScanExec, CometNativeScanExec, CometScanExec}
import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
Expand Down Expand Up @@ -1414,8 +1413,11 @@ class ParquetReadV1Suite extends ParquetReadSuite with AdaptiveSparkPlanHelper {
data: Seq[T],
f: Row => Boolean = _ => true): Unit = {
withParquetDataFrame(data) { r =>
val scans = collect(r.filter(f).queryExecution.executedPlan) { case p: CometScanExec =>
p
val scans = collect(r.filter(f).queryExecution.executedPlan) {
case p: CometScanExec =>
p
case p: CometNativeScanExec =>
p
}
if (CometConf.COMET_ENABLED.get()) {
assert(scans.nonEmpty)
Expand Down
Loading