[comet-parquet-exec] Change path handling to fix URL decoding #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbutrovich
commented
Dec 7, 2024
| field_mappings, | ||
| table_schema: Arc::<Schema>::clone(&self.table_schema), | ||
| cast_options | ||
| cast_options, |
There was a problem hiding this comment.
make format did this.
andygrove
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug with decoding paths, in particular in CometExecSuite.partition col the path has a : in it, which either wouldn't stay as
%3Aor the spaces would end up as%20or worse%2520. This cleans up the 3 tests that were failing for that reason. We might eventually want to send the original path over as a non-URL (i.e. convert on Java side) but this is good enough for now.Before:
Tests: succeeded 689, failed 67, canceled 1, ignored 47, pending 0After:
Tests: succeeded 692, failed 64, canceled 1, ignored 47, pending 0