-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement shared memory pool for case where spark.memory.offHeap.enabled=false #1002
Conversation
I'm a bit worried about this approach because we are implementing greedy mode inside |
Thanks for the feedback. I will work on a separate PR for the fair spill approach. I am moving this PR to draft for now. |
Closing in favor of #1021 |
Which issue does this PR close?
Closes #996
Rationale for this change
Simplify memory configuration.
What changes are included in this PR?
Allocate one shared pool per executor, rather than one pool per native plan, when
spark.memory.offHeap.enabled=false
.How are these changes tested?