-
Notifications
You must be signed in to change notification settings - Fork 281
Open
Description
Problem
The pending PR filter in the README badge uses status:success, which excludes PRs that have all checks passing but also have skipped iceberg matrix jobs.
The iceberg workflow (iceberg_spark_test.yml) defines matrix jobs that skip when the PR title doesn't contain [iceberg]. When skipped before matrix expansion, GitHub reports checks with unexpanded names like:
iceberg-spark/${{ matrix.os }}/iceberg-${{ matrix.iceberg-version.full }}/...
These skipped checks cause GitHub to not report the overall commit status as "success", so PRs like #3358 don't appear in the pending PR list despite all real checks passing.
Possible fixes
- Change the filter from
status:successto-status:failureso PRs are included unless they have actually failing checks - Fix the workflow to not report skipped checks — e.g. add a gate job that always succeeds and configure branch protection to use that instead of the individual matrix jobs
- Move the
ifcondition to the workflow trigger level so no checks are reported at all for non-iceberg PRs
Option 2 is the most robust but requires changing branch protection settings.
Metadata
Metadata
Assignees
Labels
No labels