Skip to content

Bloom filter intermediate aggregate buffers are not compatible between Spark and Comet #2889

@andygrove

Description

@andygrove

Describe the bug

Spark SQL test org.apache.spark.sql.BloomFilterAggregateQuerySuite fails when we allow Spark partial aggregate and Comet final aggregate:

[info]   Cause: org.apache.comet.CometNativeException: assertion `left == right` failed: Cannot merge SparkBloomFilters with different lengths.
[info]   left: 1048588
[info]  right: 1048576
[info]         at comet::errors::init::{{closure}}(__internal__:0)
[info]         at std::panicking::panic_with_hook(__internal__:0)
[info]         at std::panicking::panic_handler::{{closure}}(__internal__:0)
[info]         at std::sys::backtrace::__rust_end_short_backtrace(__internal__:0)
[info]         at __rustc::rust_begin_unwind(__internal__:0)
[info]         at core::panicking::panic_fmt(__internal__:0)
[info]         at core::panicking::assert_failed_inner(__internal__:0)
[info]         at core::panicking::assert_failed(__internal__:0)
[info]         at datafusion_comet_spark_expr::bloom_filter::bloom_filter_agg::<impl datafusion_expr_common::accumulator::Accumulator for datafusion_comet_spark_expr::bloom_filter::spark_bloom_filter::SparkBloomFilter>::merge_batch(__internal__:0)
[info]         at <futures_util::stream::stream::fuse::Fuse<S> as futures_core::stream::Stream>::poll_next(__internal__:0)
[info]         at <datafusion_physical_plan::aggregates::no_grouping::AggregateStream as futures_core::stream::Stream>::poll_next(__internal__:0)
[info]         at <datafusion_physical_plan::projection::ProjectionStream as futures_core::stream::Stream>::poll_next(__internal__:0)
[info]         at comet::execution::jni_api::Java_org_apache_comet_Native_executePlan::{{closure}}::{{closure}}(__internal__:0)
[info]         at Java_org_apache_comet_Native_executePlan(__internal__:0)
[info]         at <unknown>(__internal__:0)

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions