Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] remove outdate todo #683

Merged
merged 1 commit into from
Feb 24, 2023
Merged

[minor] remove outdate todo #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ballista/core/src/execution_plans/shuffle_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,7 @@ impl ShuffleWriterExec {
partitioner.partition(
input_batch,
|output_partition, output_batch| {
// write non-empty batch out

// TODO optimize so we don't write or fetch empty partitions
// if output_batch.num_rows() > 0 {
// partition func in datafusion make sure not write empty output_batch.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related code https://github.com/apache/arrow-datafusion/blob/ded897ee7f4944ab5ef266854e000179650b5f07/datafusion/core/src/physical_plan/repartition/mod.rs#L194-L196

let timer = write_metrics.write_time.timer();
match &mut writers[output_partition] {
Some(w) => {
Expand Down