Closed
Conversation
Enables systems that want to interface tightly with Daffodil via JAPI, to walk the runtime schema information so as to construct their own corresponding metadata. DAFFODIL-2832
mbeckerle
commented
Oct 14, 2023
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala
Show resolved
Hide resolved
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala
Show resolved
Hide resolved
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala
Show resolved
Hide resolved
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala
Show resolved
Hide resolved
tuxji
reviewed
Oct 15, 2023
Contributor
tuxji
left a comment
tuxji
left a comment
There was a problem hiding this comment.
Since this PR is still a work in progress, will only make some comments.
I agree that this new RuntimeSchemaWalker.scala's API needs unit tests with examples of how to call the API properly. I agree that some API names such as elementSimple could be better named simpleElement or startSimpleElement (without an end function).
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala
Show resolved
Hide resolved
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala
Show resolved
Hide resolved
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala
Show resolved
Hide resolved
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala
Show resolved
Hide resolved
Contributor
Author
|
Closing. Superceded by PR: Relevant comments on this have been recorded there with links back to this PR for context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For preliminary review.
Enables systems that want to interface tightly with Daffodil via JAPI, to walk the runtime schema information so as to construct their own corresponding metadata.
Done to enable Apache Drill but should be useful generally.
For use case, see PR in Apache Drill: apache/drill#2836
DAFFODIL-2832