Skip to content

replace StringUtils#notEmpty() with predicate (s -> !s.isEmpty()) #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

replace StringUtils#notEmpty() with predicate (s -> !s.isEmpty()) #2355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions core/src/main/java/org/apache/cxf/common/util/StringUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,11 @@
import java.net.URL;
import java.nio.charset.StandardCharsets;
import java.util.List;
import java.util.function.Predicate;
import java.util.regex.Matcher;
import java.util.regex.Pattern;

public final class StringUtils {

private static final Predicate<String> NOT_EMPTY = (String s) -> !s.isEmpty();

private static final char[] HEX = {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f'};

private StringUtils() {
Expand All @@ -49,10 +46,6 @@ public static boolean isEmpty(String str) {
return true;
}

public static Predicate<String> notEmpty() {
return NOT_EMPTY;
}

public static boolean isEmpty(List<String> list) {
if (list == null || list.isEmpty()) {
return true;
Expand Down
2 changes: 1 addition & 1 deletion rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ public static List<PathSegment> getPathSegments(String thePath, boolean decode,
segments.addAll(
Arrays
.stream(thePath.substring(start).split("/"))
.filter(StringUtils.notEmpty())
.filter(s -> !s.isEmpty())
.map(p -> new PathSegmentImpl(p, decode))
.collect(Collectors.toList()));

Expand Down
2 changes: 1 addition & 1 deletion ...oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/utils/OAuthUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ public static boolean isGrantSupportedForClient(Client client,

public static List<String> parseScope(String requestedScope) {
if (requestedScope != null) {
return Arrays.stream(requestedScope.split(" ")).filter(StringUtils.notEmpty()).collect(toList());
return Arrays.stream(requestedScope.split(" ")).filter(s -> !s.isEmpty()).collect(toList());
} else {
return Collections.emptyList();
}
Expand Down