Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mango): allow for overriding the host on running the tests #5219

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

pgj
Copy link
Contributor

@pgj pgj commented Sep 5, 2024

Currently it is not possible to configure the host where CouchDB is located so that the integration tests could always be run against the instance on localhost, typically launched by dev/run.

As an answer to this, consider the value of the COUCH_HOST environment variable, which is in alignment with COUCH_USER and COUCH_PASS, introduced in the past. That is completely optional, it is going to fall back to the previously assumed implict value for the localhost.

@pgj pgj force-pushed the fix/mango/tests/COUCH_HOST branch from c248595 to dda8799 Compare September 5, 2024 07:23
Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Is it to be able to run the tests against a separate cluster, not localhost?

@pgj
Copy link
Contributor Author

pgj commented Sep 6, 2024

Is it to be able to run the tests against a separate cluster, not localhost?

Yes, that is the idea behind the change. For example, it can come handy if one deployed a new CouchDB cluster and somehow wants to validate if it works as expected. Especially if Clouseau (Search) has been added as well.

Of course, other use cases might be possible. I heard about a company who used integration tests as health checks by running and reporting on them on a schedule, i.e. hourly or daily.

@pgj pgj force-pushed the fix/mango/tests/COUCH_HOST branch from dda8799 to a8be97f Compare September 6, 2024 07:07
@nickva
Copy link
Contributor

nickva commented Sep 6, 2024

@pgj ah definitely, that's a good case. Using tests as a health check is also a very neat idea.

Currently it is not possible to configure the host where CouchDB
is located so that the integration tests could always be run
against the instance on `localhost`, typically launched by
`dev/run`.

As an answer to this, consider the value of the `COUCH_HOST`
environment variable, which is in alignment with `COUCH_USER` and
`COUCH_PASS`, introduced in the past.  That is completely optional,
it is going to fall back to the previously assumed implict value
for the `localhost`.
@pgj pgj force-pushed the fix/mango/tests/COUCH_HOST branch from a8be97f to 43feeba Compare September 6, 2024 19:52
@pgj pgj merged commit 0358a82 into apache:main Sep 6, 2024
23 checks passed
@pgj pgj deleted the fix/mango/tests/COUCH_HOST branch September 6, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants