Revert "Close LRU by database path for deleted database/index" #2325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
approved these changes
Nov 22, 2019
Member
rnewson
left a comment
rnewson
left a comment
There was a problem hiding this comment.
+1. A better fix is needed, which will take some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is to revert "Close LRU by database path for deleted database/index" due to introduction of #2322 where writer can be closed before soft-deletion of index.
Testing recommendations
Related Issues or Pull Requests
#2322
#2130
cloudant-labs/clouseau#25
Checklist
rel/overlay/etc/default.ini