Skip to content

limit repeated rewriting, fixes COUCHDB-1441 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

limit repeated rewriting, fixes COUCHDB-1441 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions share/www/script/test/rewrite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,4 +437,21 @@ couchTests.rewrite = function(debug) {
var res = CouchDB.request("GET", "/test_suite_db/_design/invalid/_rewrite/foo");
TEquals(400, res.status, "should return 400");



var ddoc_loop = {
_id: "_design/loop",
rewrites: [{ "from": "loop", "to": "_rewrite/loop"}]
};
db.save(ddoc_loop);

run_on_modified_server(
[{section: "httpd",
key: "rewrite_limit",
value: "2"}],
function(){
var xhr = CouchDB.request("GET", "/test_suite_db/_design/loop/_rewrite/loop");
T(xhr.status = 400);
});

}
8 changes: 8 additions & 0 deletions src/couchdb/couch_httpd_rewrite.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,14 @@ handle_rewrite_req(#httpd{
Prefix = <<"/", DbName/binary, "/", DesignId/binary>>,
QueryList = lists:map(fun decode_query_value/1, couch_httpd:qs(Req)),

MaxRewrites = list_to_integer(couch_config:get("httpd","rewrite_limit", "100")),
NRewrites = case get('rewrite-count') of
undefined -> 1;
Number when (Number > MaxRewrites) ->
throw({bad_request, <<"Rewrite nesting exceded rewrite limit">>});
Number -> Number + 1
end,
put('rewrite-count', NRewrites),
#doc{body={Props}} = DDoc,

% get rules from ddoc
Expand Down