Can no longer `make clean` twice

[wohali]

After merging #1171, Jenkins CI started failing all Debian and Ubuntu builds.

Our Jenkins CI works by unpacking the dist tarball, running a build on it, then pulling down the couchdb-pkg repo and launching the package build.

The first step in the package build is to run make distclean on the extracted tarball, and this is failing:

ERROR: Failed to load /tmp/tmp.OQVT48xkZX/couchdb/apache-couchdb-2.2.0-3ef3149/src/couch/rebar.config: {error,
                                                                                                        {164,
                                                                                                         file,
                                                                                                         {error,
                                                                                                          {case_clause,
                                                                                                           false},
                                                                                                          [{erl_eval,
                                                                                                            expr,
                                                                                                            3,
                                                                                                            []}]}}}

The packaging code hasn't changed.

[wohali]

Reproducible with:

git reset --hard && git clean -ffdx
./configure --dev
make clean

[nickva]

I can't run make clean, does it need a ./configure before make clean can work:

$ git reset --hard && git clean -ffdx
HEAD is now at 3ef314978 re-raise max_http_request_size to 4GB
asf (master) $ make clean
make: .../asf/bin/rebar: No such file or directory
make: *** [clean] Error 1

Same result on master from 5 days ago

[wohali]

Sorry, I cut the example down too far. Yes, you need a ./configure --dev

[wohali]

@nickva if I change src/couch/rebar.config.script line 77 to _ -> it works, presumably rebar failed because there was no default branch for the case statement.

PR coming right up.

[rokek]

@wohali thank you for the fix!