Skip to content

Deprecate credentials in url #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Deprecate credentials in url #321

merged 1 commit into from
Aug 14, 2024

Conversation

YakovL
Copy link
Contributor

@YakovL YakovL commented Jan 12, 2023

Overview

This is a follow up for #174
Docs should stop suggesting the http://username:password@127.0.0.1:5984 syntax for connection and suggest using .auth instead.

Testing recommendations

I'm not sure yet if we only have to update readme.md, but at least going through it with a simple search for pass/@ is helpful to find other places to be modified.

Checklist

  • check whether there's any related PRs;
  • check if docs are stored in other places than readme.md;
    • no, examples/ don't contain any auth either; haven't reviewed all the autotests though
  • find all the places to be rewritten;
  • update content:
    • below the header "TypeScript"
    • below the header "nano.db.replicate(source, target, [opts], [callback])"
    • below the header "nano.db.replication.enable(source, target, [opts], [callback])"
    • below the header "nano.db.replication.query(id, [opts], [callback])"
    • below the header "nano.db.replication.disable(id, [opts], [callback])"

This is to create a PR where other changes to the docs can be added
@YakovL YakovL changed the title Deprecating credentials in url Deprecate credentials in url Jan 12, 2023
@YakovL YakovL mentioned this pull request Jan 13, 2023
1 task
Copy link
Contributor

@glynnbird glynnbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is sensible

@glynnbird glynnbird merged commit 8e1c24a into apache:main Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants