This repository was archived by the owner on Oct 17, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
All docs post all params #462
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In apache/couchdb#2343 the way POST _all_docs works is altered so that the same functionality is available as in GET _all_docs. This commit updates the POST _all_docs documentation to reflect this new behavior.
4 tasks
flimzy
suggested changes
Dec 6, 2019
Co-Authored-By: Jonathan Hall <flimzy@flimzy.com>
Co-Authored-By: Jonathan Hall <flimzy@flimzy.com>
Co-Authored-By: Jonathan Hall <flimzy@flimzy.com>
Co-Authored-By: Jonathan Hall <flimzy@flimzy.com>
Member
Author
|
Thank you for the review and the suggestions, @flimzy . In this PR I've managed to fix some copy-paste errors and almost introduced the same amount :) I've applied all your patches. |
flimzy
approved these changes
Dec 6, 2019
Member
flimzy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! +1
Member
I was laughing about the copy-paste errors I saw you fixing. It's funny those made it past review! Glad to see it all fixed now :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In apache/couchdb#2343 the way POST _all_docs works is altered so that the same functionality is available as in GET view.
This commit updates the POST _all_docs documentation to reflect this new behavior.
This depends on apache/couchdb#2343 .
Testing recommendations
Execute the tests seen in apache/couchdb#2343 .
Related Pull Requests
Checklist
make checkpasses with no errors