Skip to content
This repository was archived by the owner on Oct 17, 2022. It is now read-only.

Conversation

@bessbd
Copy link
Member

@bessbd bessbd commented Dec 6, 2019

Overview

In apache/couchdb#2343 the way POST _all_docs works is altered so that the same functionality is available as in GET view.

This commit updates the POST _all_docs documentation to reflect this new behavior.

This depends on apache/couchdb#2343 .

Testing recommendations

Execute the tests seen in apache/couchdb#2343 .

Related Pull Requests

Checklist

  • Documentation is written and is accurate;
  • make check passes with no errors
  • Update rebar.config.script with the commit hash once this PR is rebased and merged

Bessenyei Balázs Donát added 2 commits December 6, 2019 15:02
In apache/couchdb#2343 the way POST _all_docs works
is altered so that the same functionality is available as in GET _all_docs.

This commit updates the POST _all_docs documentation to reflect this new behavior.
bessbd and others added 4 commits December 6, 2019 16:04
Co-Authored-By: Jonathan Hall <flimzy@flimzy.com>
Co-Authored-By: Jonathan Hall <flimzy@flimzy.com>
Co-Authored-By: Jonathan Hall <flimzy@flimzy.com>
Co-Authored-By: Jonathan Hall <flimzy@flimzy.com>
@bessbd
Copy link
Member Author

bessbd commented Dec 6, 2019

Thank you for the review and the suggestions, @flimzy . In this PR I've managed to fix some copy-paste errors and almost introduced the same amount :) I've applied all your patches.

Copy link
Member

@flimzy flimzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! +1

@flimzy
Copy link
Member

flimzy commented Dec 6, 2019

In this PR I've managed to fix some copy-paste errors and almost introduced the same amount

I was laughing about the copy-paste errors I saw you fixing. It's funny those made it past review! Glad to see it all fixed now :)

@garrensmith garrensmith merged commit 6874283 into apache:master Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants