-
Notifications
You must be signed in to change notification settings - Fork 221
Documentation for partitioned dbs #385
Conversation
flimzy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, mostly minor grammatical improvements.
src/api/partitioned-dbs.rst
Outdated
| :param view: View name | ||
|
|
||
| This endpoint is responsible for executing a partitioned query. The | ||
| returned view result will only contain rows related to the specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| returned view result will only contain rows related to the specified | |
| returned view result will only contain rows stored on the specified partition. |
Is this accurate? If so, it seems more precise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reading today I went with "only contain rows with the specified partition name". "stored on" seems not quite right and I agree that "related to" seems a bit of a weak association there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 347a6ce.
|
I'm not on my normal laptop or else I'd clean this up further. Notes to self so I don't forget:
Thanks for the review @flimzy! I, apparently, do not know how to comma! |
|
@davisp also note to you, I promise to give this a more thorough read-over on Monday. |
Co-Authored-By: Jonathan Hall <flimzy@flimzy.com>
bbf9edd to
e27b050
Compare
|
@davisp |
wohali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @davisp,
This looks great. I mostly have nitpicky comments. left in the actual line-by-line review.
My big concern is that you mention nothing about partitioned DBs + Mango in this. Is there even support for Mango yet? What does that look like? If there's no support yet, put a note:: in about that. If there is support, it should be documented along with this PR, or should be in a PR to follow shortly thereafter.
Great work, and super glad to see this feature land both here and in apache/couchdb.
|
Hah, good catch! I was all like "Sure I did!" and then I thought harder and was like "oh.... maybe not". I'll make sure and add mango docs. Its very much already supported I just blanked on it. |
|
Thanks, that'd be swell, especially since your first example is all JS and I thought we were trying to push Mango more with 2.x. |
|
@davisp this really needs to land before we can release 2.4. Poke |
|
What's the current timeline for 2.4? I'll make time for this, just need to know how far out I reasonably have for trying to find a slot. |
|
I'd like to cut the first 2.4 RC after I return from my trip to Germany, and have time to recover from travel, so that'd be in 4 weeks' time, end of June. Given the early July holidays in US/CAN, I'd expect we'd release 2.4 around mid-July. Does that help? |
|
Yep. Plenty of time. Just making sure I shouldn't be shuffling my schedule for today/tomorrow and can add it in next week is all. |
wohali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
This is documentation for the new partitioned databases feature. It covers the new APIs as well as provides a guide on actually using the feature.
Testing recommendations
Um?
Related Pull Requests
Main feature PR: apache/couchdb#1789
Checklist
make checkpasses with no errors