Skip to content

Conversation

@rnewson
Copy link
Member

@rnewson rnewson commented Sep 2, 2024

No description provided.

@rnewson rnewson requested review from big-r81 and nickva September 2, 2024 08:11
fi
# newer releases have newer libmozjs
if [ "${VERSION_CODENAME}" == "noble" ]; then
apt-get install --no-install-recommends -y libmozjs-102-dev libmozjs-115-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not 102 or 115 ready for Spidermonkey...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

understood, but that's what noble comes with. the work to be compatible with sm 102/115 will happen in couchdb itself, and we'll need a CI image to test it in

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only informational: PR for v102 and v115.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, you want only prepare this already, but don't hook it into Jenkins atm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible?

# On Debian bookworm, need the --break-system-package to into to default system location
if [ "${VERSION_CODENAME}" == "bookworm" -o "${VERSION_CODENAME}" == "noble" ]; then
# On Debian bookworm and Ubuntu noble, need the --break-system-package to into to default system location
pip3 --default-timeout=10000 install --break-system-packages --upgrade sphinx_rtd_theme nose requests hypothesis==3.79.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickva Do we really need this anymore (also applies to the other CI images). I think we have our own venv in the docs folder for this, when building the docs ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it fails without it, seems we don't make a venv where we should.

# On Debian bookworm and Ubuntu noble, need the --break-system-package to into to default system location
pip3 --default-timeout=10000 install --break-system-packages --upgrade sphinx_rtd_theme nose requests hypothesis==3.79.0
else
pip3 --default-timeout=10000 install --upgrade sphinx_rtd_theme nose requests hypothesis==3.79.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.a.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it, the packages are already available, so no need to break anything

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I meant the pip3 lines, we need those only in Mango and Docs, but they create their own venv iirc…

Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks!

Sorry it took a while to get to.

I patched it up a bit make it current (java 21 and a few other changes) and most of all fixed up nodejs 18 build. It was failing for s390x architecture. However, it turns out nodejs 18 is available in the set of default packages.

The image is pushed to our CI images docker hub: https://hub.docker.com/layers/apache/couchdbci-ubuntu/noble-erlang-25.3.2.15/images/sha256-51175dbf5e9fc65bbd3deaf20890bd519dddccabddcd78941a87cec0f2be0edf?context=explore

@nickva nickva merged commit 361e07e into main Dec 8, 2024
@nickva nickva deleted the ubuntu-noble branch December 8, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants