-
Notifications
You must be signed in to change notification settings - Fork 16
add ubuntu noble numbat #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| fi | ||
| # newer releases have newer libmozjs | ||
| if [ "${VERSION_CODENAME}" == "noble" ]; then | ||
| apt-get install --no-install-recommends -y libmozjs-102-dev libmozjs-115-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not 102 or 115 ready for Spidermonkey...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
understood, but that's what noble comes with. the work to be compatible with sm 102/115 will happen in couchdb itself, and we'll need a CI image to test it in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, you want only prepare this already, but don't hook it into Jenkins atm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible?
e14bd5c to
df98e41
Compare
bin/apt-dependencies.sh
Outdated
| # On Debian bookworm, need the --break-system-package to into to default system location | ||
| if [ "${VERSION_CODENAME}" == "bookworm" -o "${VERSION_CODENAME}" == "noble" ]; then | ||
| # On Debian bookworm and Ubuntu noble, need the --break-system-package to into to default system location | ||
| pip3 --default-timeout=10000 install --break-system-packages --upgrade sphinx_rtd_theme nose requests hypothesis==3.79.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickva Do we really need this anymore (also applies to the other CI images). I think we have our own venv in the docs folder for this, when building the docs ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it fails without it, seems we don't make a venv where we should.
| # On Debian bookworm and Ubuntu noble, need the --break-system-package to into to default system location | ||
| pip3 --default-timeout=10000 install --break-system-packages --upgrade sphinx_rtd_theme nose requests hypothesis==3.79.0 | ||
| else | ||
| pip3 --default-timeout=10000 install --upgrade sphinx_rtd_theme nose requests hypothesis==3.79.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s.a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it, the packages are already available, so no need to break anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, I meant the pip3 lines, we need those only in Mango and Docs, but they create their own venv iirc…
df98e41 to
c728f52
Compare
nickva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 thanks!
Sorry it took a while to get to.
I patched it up a bit make it current (java 21 and a few other changes) and most of all fixed up nodejs 18 build. It was failing for s390x architecture. However, it turns out nodejs 18 is available in the set of default packages.
The image is pushed to our CI images docker hub: https://hub.docker.com/layers/apache/couchdbci-ubuntu/noble-erlang-25.3.2.15/images/sha256-51175dbf5e9fc65bbd3deaf20890bd519dddccabddcd78941a87cec0f2be0edf?context=explore
No description provided.