-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add Java 8 to the Docker images for running Clouseau #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e6a9505 to
78472df
Compare
78472df to
22b97ef
Compare
big-r81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thanks @big-r81 . I will not merge it for now — I have a new approach in mind but that would require changes to the CouchDB code base (the |
53c70bc to
f606b62
Compare
|
With the help of |
|
I thought the version of scala we need was incompatible with JDK 8, at least at compile time? |
|
Yes, you are right. The compilation of Clouseau does not work with JDK 8. But the created JARs could be run with that version, I have tested it on multiple platforms. |
f606b62 to
c37a106
Compare
c37a106 to
d0b631c
Compare
|
I have extended changes to Debian Bookworm and it was confirmed to be working. |
|
I noticed a failure on s390x architecture: |
This change makes it possible to run tests that require the Search functionality to be configured. Therefore the test coverage could be increased and issues could be caught with the related applications, such as Dreyfus and the `text` searches in Mango.
d0b631c to
eed45a7
Compare
|
I replaced |
|
@pgj good find! This image works so far. I am building/uploading bullseye. Once bullseye finishes I will merge the PR. |
nickva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 building worked on bullseye on all supported architectures
$ ERLANGVERSION=24.3.4.14 ./build.sh buildx-platform debian-bullseye
pushing manifest for docker.io/apache/couchdbci-debian:bullseye-erlang-24.3.4.14@sha256:a6b60ddc9d9ee8fcb8c9a76b22cfe5d7e64a0b88e0dbc32f2027f3fe65dcaa6e
|
Excellent. Thanks @nickva ! |
This change makes it possible to run tests that require the Search functionality to be configured. Therefore the test coverage could be increased and issues could be caught with the related applications, such as Dreyfus and the
textsearches in Mango.