Skip to content

CB-14190: (windows) Fix bug where double clicking <select> exits app #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iainconnor
Copy link

Double clicking on <select> elements will no longer exit the application.

Platforms affected

  • Windows.

What does this PR do?

Previously, there was code which I assume was meant to detect a click outside the webview (and on the browser wrapper), and close the webview if such a click occurs. This makes sense if the webview is treated like a popup, but the code did not check if the target of the click was the webview itself. For whatever reason, double clicking a <select> element triggered this behaviour, incorrectly closing the webview when the user is trying to interact with it.

What testing has been done on this change?

  • Tested that double clicking a <select> element no longer triggers the exit event.
  • Tested that a non-fullscreen inappbrowser still triggers the exit event if clicked outside of.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Double clicking on `<select>` elements will no longer exit the application.
@janpio
Copy link
Member

janpio commented Oct 1, 2018

Hey, I just fixed the problem that caused Android tests to fail in master. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR.

@janpio
Copy link
Member

janpio commented Oct 3, 2018

Closing and re-opening to trigger a new CI/test run with new PR merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants