CB-12366: (ios) Reduce tmpWindow level to prevent overlapping statusbar #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Thanks for the PR, I've merged it after making sure that changing the window level doesn't break the changes introduced in #187 |
DenisAtFourth
pushed a commit
to Fourth-Engage/cordova-plugin-inappbrowser
that referenced
this pull request
Jun 7, 2017
|
This PR solves one problem but creates another which is magnifying glass will show content from behind InAppBrowser. The issue is that SuppressesLongPressGesture and Suppresses3DTouchGesture cordova-ios core are ignored by InAppBrowser and current InAppBrowser content isn't displayed on magnifiying glass. By reverting everything related to magnifying glass works. |
|
@CVeniamin create an issue on issues.cordova.io if you haven't done it yet. |
|
Here it goes... CB-13488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
Reduces the window level of the
tmpWindowintroduced in #187 toUIWindowLevelNormal. With the window atUIWindowLevelAlert, I'm seeing it obscure the iOS status bar when presented.@manucorporat I'd be curious to know if the higher window level is required to solve the issues you were looking at in #187.
What testing has been done on this change?
Testing in Simulator iOS 10, Device iOS10.
Checklist