CB-9597 Adds implementation for PlatformApiPoly class according to PlatformApi spec #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! and very clean. One note about tests, jasmine spies seem to give you a lot of trouble. In the previous refactoring round I was doing, I found it very useful to entirely replace some tests that rely on spies too much with something based on filesystem fixtures with less spying. |
| } else { | ||
| delete platform_config.dependent_plugins[plugin_id]; | ||
| } | ||
| self.platformJson.addPlugin(pluginInfo.id, is_top_level); |
There was a problem hiding this comment.
FIXME: probably should be removePlugin()
|
Thanks for advice, Mark. I have some plans about tests update and definitely will try fixtures-based approach. |
|
Looks great Vlad! I'm fine with you merging this in and us spending some time testing it on master to make sure it works with all of our platforms. |
This implements PlatformApiPoly class according to PlatformApi spec, which allows to: * create/update platform * execute platform's actions (build/run/add/update) * do a prepare (needed for CLI workflow only) * install/uninstall plugins Other noticeable changes: * removes `getPlatformProject` and PlatformProject method/class in favor of PlatformApiPoly/getPlatformApi * make assets and js-modules installing/uninstalling through ActionStack * refactor configChanges to not require plugins_dir in constructor * moves mergeXml helper to xml-helpers This should be used along with cordova-cli/platformApi branch
vladimir-kotikov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements PlatformApiPoly class according to PlatformApi spec, which allows to:
Other noticeable changes:
getPlatformProjectand PlatformProject method/class in favor of PlatformApiPoly/getPlatformApiThis should be used along with cordova-cli/platformApi branch: apache/cordova-cli#220