fix(create): Copy config.xml data during creation

[dpogue]

Platforms affected

iOS

Motivation and Context

This ensures that by the time plugin installation happens, the preferences from the root application config.xml can be read as expected.

Closes GH-1422.

Description

Merge the app's config.xml into the defaults.xml at creation time for the platform config.xml.

Also removed comments about the link option since that's no longer relevant (with CordovaLib consumed as a Swift package, it is always linked).

Testing

Existing tests pass, and added a new unit test to verify new behaviour.

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.97%. Comparing base (18a80d2) to head (dc2587b).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
+ Coverage   80.86%   80.97%   +0.10%     
==========================================
  Files          16       16              
  Lines        1840     1850      +10     
==========================================
+ Hits         1488     1498      +10     
  Misses        352      352              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[erisu]

Code LGTM

[jkronborg]

Hi, thanks for the fix!

The issue fixed here prevents us from upgrading to version 17 of cordova-plugin-firebasex because our minimum deployment version setting of 14 is not being set in time for the plugin installation, meaning the Cordova default of 11 is used, causing the build to fail (Firebase v. 11 requires a minimum target of at least 13):

[!] CocoaPods could not find compatible versions for pod "FirebaseAuth": In Podfile: FirebaseAuth (= 11.2.0) Specs satisfying the FirebaseAuth (= 11.2.0) dependency were found, but they required a higher minimum deployment target.

This plugin upgrade is a requirement for building with Xcode 16 due to dpa99c/cordova-plugin-firebasex#892, which Apple requires by April 24.

Do you plan to release this before April 24?

[dpogue]

Do you plan to release this before April 24?

Due to the volunteer nature of Cordova development and maintenance, we can't make any commitments around release timelines.

This will be part of the cordova-ios 8.0.0 major version, and there are a few other big features to wrap up for that, namely support for Swift Package Manager.

[jkronborg]

Do you plan to release this before April 24?

Due to the volunteer nature of Cordova development and maintenance, we can't make any commitments around release timelines.

This will be part of the cordova-ios 8.0.0 major version, and there are a few other big features to wrap up for that, namely support for Swift Package Manager.

OK, makes sense. Just wanted to make you aware of the issue, as I imagine quite a few Cordova projects use the Firebase plugin. I'll try to find an acceptable workaround.

Thanks for all your work on Cordova 🙏

[jkronborg]

Our actual issue turned out to be ionic-team/cordova-plugin-ionic-webview#695. Sorry for the confusion.