Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Various ObjC/template cleanups #1354

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jun 29, 2023

Replaces #1347 since something went wrong with rebasing there 😕

Platforms affected

iOS

Motivation and Context

Minor cleanup and modernization of the Xcode project structure to better align with current Xcode conventions.

Description

  • Moved application classes out of the Classes folder and to the root of the Xcode project.
  • Removed several debug information prints to the console on app launch that have not been useful for several years.
  • Only print the Cordova version to the console in debug mode (to avoid exposing framework information on all Cordova apps)

Testing

All unit tests pass.
Builds successfully in Xcode.

Checklist

  • I've run the tests to see all new and existing tests pass

@dpogue dpogue added this to the 7.0.0 milestone Jun 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #1354 (d079951) into master (ad57677) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1354   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files          15       15           
  Lines        1789     1789           
=======================================
  Hits         1400     1400           
  Misses        389      389           
Impacted Files Coverage Δ
lib/create.js 94.59% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Tested building of default app and custom app.

@erisu erisu merged commit 77b4689 into apache:master Jul 5, 2023
@dpogue dpogue deleted the objc-cleanup branch March 8, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants