-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: add plugin support #175
Conversation
7de6b15
to
3d1f5a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 625 652 +27
=========================================
+ Hits 625 652 +27
Continue to review full report at Codecov.
|
a2a867b
to
cc4fbd0
Compare
Last call... Merging soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick test with instructions from @erisu:
// Create a project
cordova create cordovaTest com.erisu.cordovaTest cordovaTest && $_
// Add Cordova Electron w/ Plugin Support
cordova platform add github:erisu/cordova-electron\#feat/plugin-support
// Add Cordova Device Plugin w/ Electron Support
cordova plugin add github:erisu/cordova-plugin-device\#feat/electron-support
// Build or run or what ever
cordova run electron --nobuild
cordova build electron
// Uninstall plugin test
cordova plugin rm cordova-plugin-device
The test went well and from my limited knowledge the code looks good. Go for it and bring plugins to electron!
cc4fbd0
to
c032188
Compare
Motivation and Context
contextIsolation
&preload
Description
node_modules
andpackage.json
exec
method to support he new electron implementation but keep the browser fallback when electron is missing.exec
& Electon's nativeipcRenderer
.cordova.js
'sexec
method to use the Cordova Electron's custom bridge.Testing
Requires
Checklist