Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint violations where applicable #83

Merged
merged 2 commits into from
Jul 18, 2019

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Jul 18, 2019

Fixes most ESLint violations that were masked by ESLint comments. Two instances still remain. One is an acceptable usage of eval and the other is in CordovaError that should be fixed by its own commit.

I noticed I had this lying around in my local fork when I reviewed #82.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raphinesse raphinesse merged commit ea24546 into apache:master Jul 18, 2019
@raphinesse raphinesse deleted the eslint-comments branch July 18, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants