Skip to content

CB-13145: added variable replacing to framework tag #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

stevengill
Copy link
Contributor

Still need to add a test.

This is for allowing framework tags in plugin.xml to have variables defined and replaced via the <preference> tag also in plugin.xml

Example

<preference name="FCM_VERSION" default="11.0.1"/>

<framework src="com.google.firebase:firebase-messaging:$FCM_VERSION"/>

$FCM_VERSION would get replaced with 11.0.1 when being written to project.properties and build.gradle.

@stevengill
Copy link
Contributor Author

This pr needs to be linked with cordova-lib to test this functionality.

@codecov-io
Copy link

codecov-io commented Aug 18, 2017

Codecov Report

Merging #4 into master will decrease coverage by 0.08%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   84.42%   84.33%   -0.09%     
==========================================
  Files          19       19              
  Lines        1746     1756      +10     
  Branches      369      373       +4     
==========================================
+ Hits         1474     1481       +7     
- Misses        272      275       +3
Impacted Files Coverage Δ
src/PluginManager.js 92.45% <100%> (ø) ⬆️
src/PluginInfo/PluginInfo.js 76.13% <75%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af5c6dc...7f38f6b. Read the comment docs.

@stevengill stevengill force-pushed the CB-13145 branch 2 times, most recently from 239c7cc to ca22617 Compare August 18, 2017 06:24
@goya
Copy link
Member

goya commented Aug 18, 2017

id use global variable elements for this. preferences should be used for platform or core use. the preference namespace should be explicitly different to an assumed namespace of regex for random plugin authors.

@stevengill stevengill force-pushed the CB-13145 branch 2 times, most recently from 8f8887e to 8988dc8 Compare August 22, 2017 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants