Skip to content

Conversation

mgatto
Copy link

@mgatto mgatto commented Jul 14, 2023

Platforms affected

Browser

Motivation and Context

Closes #122.

Description

This PR adds a new boolean option --https which will serve the browser platform over HTTPS.

These issues is other Cordova repos are also required:

Testing

A test for cordova run browser seems not to be present in this repo (?).

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.75%. Comparing base (66d9e2e) to head (857821c).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files           2        2           
  Lines          32       32           
=======================================
  Hits           30       30           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serve over HTTPS

2 participants