Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove trailing spaces from Java sources #999

Merged

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jun 10, 2020

Platforms affected

Android

Motivation and Context

see title

Description

see title

Testing

npm test in my work area - OK
✅ tried using in cordova-sqlite-storage test app - OK

Checklist

  • I've run the tests to see all new and existing tests pass - both in work area and in GitHub CI
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #999 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #999   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files          21       21           
  Lines        1866     1866           
=======================================
  Hits         1271     1271           
  Misses        595      595           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dead4b4...b121a10. Read the comment docs.

@brodycj brodycj marked this pull request as ready for review June 10, 2020 02:57
@brodycj
Copy link
Contributor Author

brodycj commented Jun 10, 2020

In general, I think we should do this cleanup through all of our repositories and look for a way to avoid trailing whitespaces in the future. I learned about git grep pretty recently, looks like a good friend, and discovered this for finding tabs: https://stackoverflow.com/questions/4262150/is-it-possible-to-git-grep-for-tabs

@breautek
Copy link
Contributor

Could even look at implementing java/android lint

https://developer.android.com/studio/write/lint

@brodycj brodycj merged commit 80b7a7f into apache:master Jun 16, 2020
@brodycj brodycj deleted the cleanup-remove-trailing-spaces-from-java-sources branch June 16, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants