feat: add google services support #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
changed the title
erisu
force-pushed
the
feat/enable-google-services-plugin
branch
from
917b463
to
ee832dc
Compare
erisu
force-pushed
the
feat/enable-google-services-plugin
branch
from
ee832dc
to
3af5a08
Compare
dpogue
approved these changes
Jan 15, 2020
| @@ -356,3 +377,7 @@ for (def func : cdvPluginPostBuildExtras) { | |||
| if (hasProperty('postBuildExtras')) { | |||
| postBuildExtras() | |||
| } | |||
|
|
|||
| if (cdvHelpers.getConfigPreference('GoogleServicesEnable', 'false').toBoolean()) { | |||
| apply plugin: 'com.google.gms.google-services' | |||
There was a problem hiding this comment.
In my plugin when I do this, for some reason it needs to be the full path to the plugin, not just the string... I think that might have had something to do with being a subproject though
apply plugin: com.google.gms.googleservices.GoogleServicesPlugin
|
@erisu IMO current names a bit confusing. There are different google services that do not require this plugin (Maps, Ads etc.). So I suggest to change names to something like |
|
@erisu 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To finish off the change requests and close out PR #438
closes: #438
Description
What this PR does:
GoogleServicesEnabledflag.GoogleServicesVersionpreference variable that allows users to override the default to use older or newer Google Services classpath. (Defaults to:4.2.0)Testing
npm tcordova platform addcordova build androidpreferenceattributes.GoogleServicesEnabledset totrueGoogleServicesEnabledset totrueandGoogleServicesVersionset to4.1.0Checklist