Prevent exit fullscreen mode from closing application #823

Chuckytuh · 2019-08-29T18:41:51Z

Platforms affected

Android

Motivation and Context

This PR proposes a simple, quick, solution to overcome a problem with full screen mode that, when on and back button is pressed, the application is closed instead of exiting full screen.

For more details see #822 and also https://bugs.chromium.org/p/chromium/issues/detail?id=999212

Fixes #822

Description

The custom view provided by WebKit on SystemWebChromeClients's onShowCustomView method is wrapped in a custom FrameLayout in order to be able to grab key events and redirect them into SystemWebView's dispatchKeyEvent.

Given that the custom view is the one with the focus, that's the one handling input, for this reason, we can hijack those key events and redirect them so that they end up closing the custom view because, as stated on the linked chromium bug (#999212), the onHideCustomView method from the WebChromeClient subclass is not being executed for recent versions of Chrome, hence, not exiting full screen mode and instead, closing the MainActivity/ Application.

Testing

Manual tests on a Pixel (Android 7.1.2) and Pixel 2 XL (Android 10) with Chrome updated to the most recent version.

Checklist

I've run the tests to see all new and existing tests pass
I added automated test coverage as appropriate for this change
Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
I've updated the documentation if necessary

Wraps the custom view in a FrameLayout in order to capture key events and redirect them to SystemWebView's dispatchKeyEvent.

breautek · 2019-10-09T12:15:49Z

full screen mode

When you say this, do you mean when the application has the FullScreen preference enabled? Or when you have a video player open and you hit the full screen button? Or both?

I'll try to test this tonight.

itsvick · 2019-10-15T20:27:57Z

@breautek Any update on this?
I have the same issue when pressing the fullscreen button from the video.

breautek

Tested 8.1.0 on chrome webview 77 and confirmed the issue appears, and confirmed that this PR fixes the issue with no obvious side effects.

I've also tested this on chrome webview 69 via emulator and it didn't exhibit the original issue.

Chuckytuh · 2019-10-16T05:18:12Z

When you say this, do you mean when the application has the FullScreen preference enabled? Or when you have a video player open and you hit the full screen button? Or both?

Sorry for the late reply, I meant full screen mode on html video player.

patchon · 2019-10-26T15:09:54Z

Hi,

I recently stumbled on this on an application I'm developing.
It uses a javascript video-player (plyr.js), and the problem is as described (back button from fullscreen exits the app).

I've applied the commit fdc4da5 and now backbutton works as expected.

Almost anyway :)

What happens is,

If I go fullscreen, then
Press backbutton, then
Press backbutton again
App exits (which it shouldn't since I have an handler registered that should popup a question if I really want to exit before exiting).

It works correctly though, if you do it like this

If I go fullscreen, then
Press backbutton, then
Touches somewhere in the app (on the background for example), then
Press backbutton,
Registered handler popups a question whether I want to exit or not (ie. it works as expected).

I have the following logs from logcat,
Works correctly

2019-10-26 16:53:32.633 4042-4042/? D/LightBarController: onNavigationVisibilityChanged mNavigationLight = false
2019-10-26 16:53:32.643 4042-4042/? D/StatusBar: Status bar WINDOW_STATE_SHOWING
2019-10-26 16:53:32.644 4042-4042/? D/OverviewProxyService: SystemUi flags: 2
2019-10-26 16:53:32.646 13826-22583/? D/TouchInteractionService: onSystemUiStateChanged# stateFlags: 2
2019-10-26 16:53:32.646 4042-4042/? D/OverviewProxyService: SystemUi flags: 2
2019-10-26 16:53:32.646 13826-22583/? D/TouchInteractionService: onSystemUiStateChanged# stateFlags: 2
2019-10-26 16:53:32.646 4042-4042/? D/NavigationBar: Navigation bar WINDOW_STATE_SHOWING
2019-10-26 16:53:32.647 4042-4042/? D/OverviewProxyService: SystemUi flags: 0
2019-10-26 16:53:32.647 13826-22583/? D/TouchInteractionService: onSystemUiStateChanged# stateFlags: 0
2019-10-26 16:53:33.121 4042-4042/? I/KeyButtonView: Back button event: ACTION_DOWN
    
    --------- beginning of system
2019-10-26 16:53:33.124 1277-5925/? D/VibratorService: vibrate from 'android', usageHint = 13
2019-10-26 16:53:33.172 4042-4042/? I/KeyButtonView: Back button event: ACTION_UP
2019-10-26 16:53:33.172 13826-22583/? D/TouchInteractionService: onBackAction#
2019-10-26 16:53:33.250 19090-19090/io.my-app D/SystemWebChromeClient: https://my-app/assets/js/navigation.js: Line 177 : Nothing to go back to, popping up exit dialog..
2019-10-26 16:46:55.697 18294-18314/io.my-app D/DecorView: onWindowFocusChangedFromViewRoot hasFocus: true, DecorView@b70400a[MainActivity]
2019-10-26 16:46:55.709 18294-18294/io.my-app W/Choreographer: Already have a pending vsync event.  There should only be one at a time.

Does not work correctly

2019-10-26 16:51:46.239 4042-4042/? D/LightBarController: onNavigationVisibilityChanged mNavigationLight = false
2019-10-26 16:51:46.260 4042-4042/? D/StatusBar: Status bar WINDOW_STATE_SHOWING
2019-10-26 16:51:46.262 4042-4042/? D/OverviewProxyService: SystemUi flags: 2
2019-10-26 16:51:46.262 13826-22583/? D/TouchInteractionService: onSystemUiStateChanged# stateFlags: 2
2019-10-26 16:51:46.263 4042-4042/? D/OverviewProxyService: SystemUi flags: 2
2019-10-26 16:51:46.263 13826-22583/? D/TouchInteractionService: onSystemUiStateChanged# stateFlags: 2
2019-10-26 16:51:46.263 4042-4042/? D/NavigationBar: Navigation bar WINDOW_STATE_SHOWING
2019-10-26 16:51:46.263 4042-4042/? D/OverviewProxyService: SystemUi flags: 0
2019-10-26 16:51:46.264 13826-22583/? D/TouchInteractionService: onSystemUiStateChanged# stateFlags: 0
2019-10-26 16:51:46.594 4042-4042/? I/KeyButtonView: Back button event: ACTION_DOWN
    
    --------- beginning of system
2019-10-26 16:51:46.597 1277-6554/? D/VibratorService: vibrate from 'android', usageHint = 13
2019-10-26 16:51:46.653 4042-4042/? I/KeyButtonView: Back button event: ACTION_UP
2019-10-26 16:51:46.654 13826-22583/? D/TouchInteractionService: onBackAction#
2019-10-26 16:51:46.661 1277-5925/? D/OpQuickReply: setQuickReplyResumed focusedApp AppWindowToken{9230f7c token=Token{f1f966f ActivityRecord{b3ce54e u0 com.teslacoilsw.launcher/.NovaLauncher t8082}}} pkgName com.teslacoilsw.launcher
2019-10-26 16:46:20.052 1277-4389/? D/OpSlaNetlinkHelper: frontPackageChanged: com.teslacoilsw.launcher uid:10136 pid:32020 | io.my-app uid:10298 pid:18294
2019-10-26 16:46:20.062 18294-18294/io.my-app D/CordovaActivity: Paused the activity.
2019-10-26 16:46:20.176 18294-18294/io.my-app D/CordovaActivity: Stopped the activity.
2019-10-26 16:46:20.177 18294-18294/io.my-app I/Surface: opservice is null false
2019-10-26 16:46:20.178 18294-18294/io.my-app D/CordovaActivity: CordovaActivity.onDestroy()
2019-10-26 16:46:20.178 18294-18294/io.my-app D/CordovaWebViewImpl: >>> loadUrl(about:blank)
2019-10-26 16:46:20.179 18294-18294/io.my-app W/cr_AwContents: WebView.destroy() called while WebView is still attached to window.
2019-10-26 16:46:20.196 18294-18294/io.my-app W/cr_AwContents: Application attempted to call on a destroyed WebView
    java.lang.Throwable
        at org.chromium.android_webview.AwContents.c(PG:3)
        at org.chromium.android_webview.AwContents.T(PG:1)
        at Io.loadingStateChanged(PG:1)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:336)
        at android.os.Looper.loop(Looper.java:174)
        at android.app.ActivityThread.main(ActivityThread.java:7682)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:516)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)

It seems like, when pressing the back button twice in a row (ie. not touching anything in the app between), it fires the fires the "stop activity" and then the "destroy activity", which is not the case when I press something in the app between the "back button presses".

Any ideas about this ?
Are you able to reproduce it ?

l-hwen

Sorry, I followed the instructions to modify my file, but this still doesn't work for me.
Cordova-android@8.1.0
@breautek

erisu

Everything looked OK but there was some formatting that could be corrected. It seems the PR added some extra whitespace/newlines that were not needed or in the wrong place.

Could you correct these?

framework/src/org/apache/cordova/CordovaWebViewImpl.java

Co-Authored-By: エリス <erisu@users.noreply.github.com>

timbru31 · 2020-04-14T11:50:59Z

@breautek - Unfortunately, the newlines around line 520 (@Override) are still off.

Chuckytuh · 2020-04-14T13:00:12Z

Formatting should now be right

timbru31

Thanks!

PhamNguyenNL · 2020-04-20T08:11:41Z

Could you please create a new release/tag for this? This is currently only fixed on the master branch.

timbru31 · 2020-04-20T08:13:00Z

Not an extra release, but cordova-android@9 will be released soonish.

simion · 2020-04-23T19:16:22Z

I need this fix too :) please release

Hanzofm · 2021-04-23T06:53:43Z

Hi @patchon,

For me still not working with cordova-android 9.0.0 where is merged this PR. Same problem of you with plyr.js.

(android) wrap custom view in FrameLayout

fdc4da5

Wraps the custom view in a FrameLayout in order to capture key events and redirect them to SystemWebView's dispatchKeyEvent.

itsvick mentioned this pull request Oct 15, 2019

Back Button after FullScreen Mode crash the app ionic-team/ionic-framework#19662

Closed

breautek approved these changes Oct 16, 2019

View reviewed changes

breautek requested review from dpogue and knight9999 October 16, 2019 03:26

breautek mentioned this pull request Nov 2, 2019

Back Button after Full Screen Mode #839

Closed

l-hwen reviewed Nov 2, 2019

View reviewed changes

patchon mentioned this pull request Nov 3, 2019

Back button event on full screen video closes application #822

Closed

3 tasks

paulstelzer mentioned this pull request Nov 20, 2019

bug: App close on hardware back button press when video is open in full screen. ionic-team/ionic-framework#19356

Closed

erisu requested changes Jan 6, 2020

View reviewed changes

framework/src/org/apache/cordova/CordovaWebViewImpl.java Outdated Show resolved Hide resolved

framework/src/org/apache/cordova/CordovaWebViewImpl.java Outdated Show resolved Hide resolved

framework/src/org/apache/cordova/CordovaWebViewImpl.java Outdated Show resolved Hide resolved

erisu added the enhancement label Jan 6, 2020

erisu added this to the 9.0.0 milestone Jan 6, 2020

breautek and others added 3 commits April 13, 2020 21:13

Update framework/src/org/apache/cordova/CordovaWebViewImpl.java

7664a5c

Co-Authored-By: エリス <erisu@users.noreply.github.com>

Update framework/src/org/apache/cordova/CordovaWebViewImpl.java

f183807

Co-Authored-By: エリス <erisu@users.noreply.github.com>

Update framework/src/org/apache/cordova/CordovaWebViewImpl.java

6847442

Co-Authored-By: エリス <erisu@users.noreply.github.com>

breautek requested a review from erisu April 14, 2020 00:22

remove empty line below @OverRide

c4c280b

timbru31 approved these changes Apr 14, 2020

View reviewed changes

timbru31 merged commit 71f63d7 into apache:master Apr 14, 2020

Chuckytuh deleted the fix/fullscreenbackbutton branch April 14, 2020 18:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent exit fullscreen mode from closing application #823

Prevent exit fullscreen mode from closing application #823

Chuckytuh commented Aug 29, 2019

breautek commented Oct 9, 2019

itsvick commented Oct 15, 2019

breautek left a comment •

edited

Loading

Chuckytuh commented Oct 16, 2019

patchon commented Oct 26, 2019

l-hwen left a comment •

edited

Loading

erisu left a comment

timbru31 commented Apr 14, 2020

Chuckytuh commented Apr 14, 2020 •

edited

Loading

timbru31 left a comment

PhamNguyenNL commented Apr 20, 2020 •

edited

Loading

timbru31 commented Apr 20, 2020

simion commented Apr 23, 2020

Hanzofm commented Apr 23, 2021

Prevent exit fullscreen mode from closing application #823

Prevent exit fullscreen mode from closing application #823

Conversation

Chuckytuh commented Aug 29, 2019

Platforms affected

Motivation and Context

Description

Testing

Checklist

breautek commented Oct 9, 2019

itsvick commented Oct 15, 2019

breautek left a comment • edited Loading

Choose a reason for hiding this comment

Chuckytuh commented Oct 16, 2019

patchon commented Oct 26, 2019

l-hwen left a comment • edited Loading

Choose a reason for hiding this comment

erisu left a comment

Choose a reason for hiding this comment

timbru31 commented Apr 14, 2020

Chuckytuh commented Apr 14, 2020 • edited Loading

timbru31 left a comment

Choose a reason for hiding this comment

PhamNguyenNL commented Apr 20, 2020 • edited Loading

timbru31 commented Apr 20, 2020

simion commented Apr 23, 2020

Hanzofm commented Apr 23, 2021

breautek left a comment •

edited

Loading

l-hwen left a comment •

edited

Loading

Chuckytuh commented Apr 14, 2020 •

edited

Loading

PhamNguyenNL commented Apr 20, 2020 •

edited

Loading